Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Boefje runonce functionality in scheduler #3906

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jpbruinsslot
Copy link
Contributor

@jpbruinsslot jpbruinsslot commented Nov 28, 2024

Changes

With the specification on the plugin definition of runon the BoefjeScheduler should be able to discern between task that needs to run once or that a schedule needs to be created, and based on what type of mutation (CREATE , UPDATE).

When a schedule or when a task needs to be run is laid out in this table #3879 (comment)

Note that the create_schedule attribute on a Scheduler always takes precedence. When this is set to False under no circumstances a schedule will be created. As is the case with the NormalizerScheduler.

Reviewer notes

Tests for the outcomes of the mentioned table should be made. This is as of yet untested, but can be reviewed, and qa'ed.

Issue link

Closes #3879

QA notes

Should be able to work with the following pr #3901

Reference this table #3879 (comment)

These paths should be tested

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@jpbruinsslot jpbruinsslot added the mula Issues related to the scheduler label Nov 28, 2024
@jpbruinsslot jpbruinsslot self-assigned this Nov 28, 2024
@jpbruinsslot jpbruinsslot requested a review from a team as a code owner November 28, 2024 11:46
@jpbruinsslot jpbruinsslot linked an issue Nov 28, 2024 that may be closed by this pull request
@jpbruinsslot jpbruinsslot marked this pull request as draft November 28, 2024 12:36
@jpbruinsslot jpbruinsslot changed the title Boefje runonce functionality in scheduler [WIP] Boefje runonce functionality in scheduler Nov 28, 2024
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
17.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mula Issues related to the scheduler
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

Run boefje once at creation or update of ooi
1 participant